changed std.json.Value to unmanaged defaults#25723
Open
gh22749268 wants to merge 3 commits intoziglang:masterfrom
Open
changed std.json.Value to unmanaged defaults#25723gh22749268 wants to merge 3 commits intoziglang:masterfrom
gh22749268 wants to merge 3 commits intoziglang:masterfrom
Conversation
Previous commit introduced new layer of comlexity, without any actuall benefits. This way we can have more dynamic sized union and reduce memory footprint.
Having ObjectMap point to object_unmanaged, could be confusing and that way it should be more compatible with existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25719