Skip to content

Update api.ts, fix & augment museum types#462

Merged
zikeji merged 7 commits intomainfrom
dev
Jul 19, 2025
Merged

Update api.ts, fix & augment museum types#462
zikeji merged 7 commits intomainfrom
dev

Conversation

@zikeji
Copy link
Owner

@zikeji zikeji commented Jul 19, 2025

Solves #461.

@zikeji zikeji requested a review from Copilot July 19, 2025 07:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves TypeScript typing for SkyBlock museum data and other API objects by replacing unknown types with more specific indexed object types. The changes enhance type safety and provide better development experience when working with museum items and various API response objects.

Key changes:

  • Replace numerous unknown types with { [key: string]: unknown } for better type safety
  • Create new augmented types specifically for SkyBlock museum members and items
  • Add changelog configuration for tracking type improvements

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/types/api.ts Replaces unknown types with indexed object types across multiple API interfaces
src/types/AugmentedTypes.ts Updates museum response type to use new augmented museum member type
src/types/Augmented/SkyBlock/Museum.ts Defines new types for museum items and members with proper structure
package.json Adds changelog section for tracking API type coverage improvements

@zikeji zikeji added the enhancement New feature or request label Jul 19, 2025
@zikeji zikeji self-assigned this Jul 19, 2025
@zikeji zikeji merged commit 8412aff into main Jul 19, 2025
10 checks passed
@zikeji-s-semantic-releaser
Copy link

🎉 This PR is included in version 4.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant