Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves TypeScript typing for SkyBlock museum data and other API objects by replacing unknown types with more specific indexed object types. The changes enhance type safety and provide better development experience when working with museum items and various API response objects.
Key changes:
- Replace numerous
unknowntypes with{ [key: string]: unknown }for better type safety - Create new augmented types specifically for SkyBlock museum members and items
- Add changelog configuration for tracking type improvements
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/types/api.ts | Replaces unknown types with indexed object types across multiple API interfaces |
| src/types/AugmentedTypes.ts | Updates museum response type to use new augmented museum member type |
| src/types/Augmented/SkyBlock/Museum.ts | Defines new types for museum items and members with proper structure |
| package.json | Adds changelog section for tracking API type coverage improvements |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 4.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #461.