Pass thru twigOptions to compiler regardless of code path#61
Open
gavrielrh wants to merge 1 commit intozimmo-be:masterfrom
Open
Pass thru twigOptions to compiler regardless of code path#61gavrielrh wants to merge 1 commit intozimmo-be:masterfrom
gavrielrh wants to merge 1 commit intozimmo-be:masterfrom
Conversation
When options are provided to this loader via webpack config, they should always pass thru to the compiler regardless of which codepath is taken. This unfortunately isn't the case for all webpack configs, resulting in critical options like autoescape: true not being seen when compiling .twig files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 🙂
Thank you for maintaining this library!
When investigating the cause of some twig templates not behaving the way I'd expect, I found that options I had set in my webpack.config.js weren't actually applying when the twig-loader was creating js output.
Specifically, I was expecting:
to pass through the
autoescape: trueoption to twigjs, such that the resulting js output would resemble the followingbut instead the autoescape option was completely missing from the generated template.
This PR should remedy it, but I'd be more than happy to know if I'm missing something / if there's a better approach.