Implement From<Box<dyn Diagnostic>> for MietteDiagnostic#454
Open
walker84837 wants to merge 2 commits intozkat:mainfrom
Open
Implement From<Box<dyn Diagnostic>> for MietteDiagnostic#454walker84837 wants to merge 2 commits intozkat:mainfrom
From<Box<dyn Diagnostic>> for MietteDiagnostic#454walker84837 wants to merge 2 commits intozkat:mainfrom
Conversation
Contributor
|
When would this be helpful? Just seeking to understand, given the lack of PR description (not my project, not my call what to merge). |
Author
|
Sorry for not providing a description earlier. This PR adds an implementation of Off the top of my head, here are some reasons why you might want something like this:
zkat mentioned in #285 that a PR would be welcome, so this implements that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables converting
Box<dyn Diagnostic>intoMietteDiagnostic, so boxed errors can be turned into miette's structured diagnostic type without extra boilerplate. This matches miette's use ofMietteDiagnosticas the standard runtime-built diagnostic, and fills a missing conversion path for trait-object errors. It's useful whenever errors are erased behindBox<dyn Diagnostic>and later need to be reported through miette (like in logging or serialization). Fixes #285.