Skip to content

Improve PDF worker controller#1218

Merged
mvasilak merged 10 commits intozotero:masterfrom
mvasilak:improve-pdf-worker-controller
Dec 24, 2025
Merged

Improve PDF worker controller#1218
mvasilak merged 10 commits intozotero:masterfrom
mvasilak:improve-pdf-worker-controller

Conversation

@mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Dec 17, 2025

  • Adds support for workers, which group works for the same file, so that the relevant web view handler is reused.
  • Adds support for different priorities, for using higher priority when extracting text for speech.
  • Adds more relevant tests.

@mvasilak mvasilak merged commit 6708119 into zotero:master Dec 24, 2025
1 check failed
@mvasilak mvasilak deleted the improve-pdf-worker-controller branch December 24, 2025 14:19
@michalrentka
Copy link
Contributor

@mvasilak I went through your latest changes. Looks good. Maybe one note for future if needed. If a preloadedPDFWorkerWebViewHandler is used up in func queue(work: Work, in worker: Worker) -> Observable<Update> it could be nice to pre-load another one (just one preloadPDFWorkerIfIdle() call after line 210 in PDFWorkerController I believe). But if performance is not an issue at this point, it might not be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants