Add utility function for incremental response.#462
Open
chrischen wants to merge 3 commits intozth:masterfrom
Open
Add utility function for incremental response.#462chrischen wants to merge 3 commits intozth:masterfrom
chrischen wants to merge 3 commits intozth:masterfrom
Conversation
added 2 commits
August 15, 2023 11:32
Add utility function to convert GraphQL spec incremental response for @defer/@stream fragments so that they work with the expected shape from Relay.
Refactor Defer response converter so that the unsafe magic JS external function is just the object merge. Also implement a type-safe converter using object types, though it may not be necessary in the future as this problem should be resolved if Relay starts conforming to spec.
zth
reviewed
Aug 21, 2023
Fix type errors for the interface file. Reimplement to avoid use of Array.filterMap which is included in Rescript Core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add utility function to convert GraphQL spec incremental response for @defer/@stream fragments so that they work with the expected shape from Relay.