Skip to content

Detect non-width spaces #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wvddrss wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Detect non-width spaces #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83ba83
Detect non-width spaces
Jul 17, 2023
a9d2984
Merge branch 'master' into bugfix/detect-non-width-spaces
wvddrss Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dist/tribute.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,10 @@ class TributeRange {
}
}

convertNonWidthSpacesToRealOnes(text) {
return text.replace(/[\u200B-\u200D\uFEFF]/g, ' ')
}

getTextPrecedingCurrentSelection() {
let context = this.tribute.current,
text = '';
Expand All @@ -721,7 +725,7 @@ class TributeRange {
let selectedElem = this.getWindowSelection().anchorNode;

if (selectedElem != null) {
let workingNodeContent = selectedElem.textContent;
let workingNodeContent = this.convertNonWidthSpacesToRealOnes(selectedElem.textContent);
let selectStartOffset = this.getWindowSelection().getRangeAt(0).startOffset;

if (workingNodeContent && selectStartOffset >= 0) {
Expand Down
9 changes: 8 additions & 1 deletion dist/tribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@

(function(l, r) { if (l.getElementById('livereloadscript')) return; r = l.createElement('script'); r.async = 1; r.src = '//' + (window.location.host || 'localhost').split(':')[0] + ':35729/livereload.js?snipver=1'; r.id = 'livereloadscript'; l.head.appendChild(r) })(window.document);
(function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
Expand Down Expand Up @@ -773,6 +775,11 @@
};
}
}
}, {
key: "convertNonWidthSpacesToRealOnes",
value: function convertNonWidthSpacesToRealOnes(text) {
return text.replace(/[\u200B-\u200D\uFEFF]/g, ' ');
}
}, {
key: "getTextPrecedingCurrentSelection",
value: function getTextPrecedingCurrentSelection() {
Expand All @@ -793,7 +800,7 @@
var selectedElem = this.getWindowSelection().anchorNode;

if (selectedElem != null) {
var workingNodeContent = selectedElem.textContent;
var workingNodeContent = this.convertNonWidthSpacesToRealOnes(selectedElem.textContent);
var selectStartOffset = this.getWindowSelection().getRangeAt(0).startOffset;

if (workingNodeContent && selectStartOffset >= 0) {
Expand Down
2 changes: 1 addition & 1 deletion dist/tribute.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/tribute.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 8 additions & 1 deletion example/tribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@

(function(l, r) { if (l.getElementById('livereloadscript')) return; r = l.createElement('script'); r.async = 1; r.src = '//' + (window.location.host || 'localhost').split(':')[0] + ':35729/livereload.js?snipver=1'; r.id = 'livereloadscript'; l.head.appendChild(r) })(window.document);
(function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
Expand Down Expand Up @@ -773,6 +775,11 @@
};
}
}
}, {
key: "convertNonWidthSpacesToRealOnes",
value: function convertNonWidthSpacesToRealOnes(text) {
return text.replace(/[\u200B-\u200D\uFEFF]/g, ' ');
}
}, {
key: "getTextPrecedingCurrentSelection",
value: function getTextPrecedingCurrentSelection() {
Expand All @@ -793,7 +800,7 @@
var selectedElem = this.getWindowSelection().anchorNode;

if (selectedElem != null) {
var workingNodeContent = selectedElem.textContent;
var workingNodeContent = this.convertNonWidthSpacesToRealOnes(selectedElem.textContent);
var selectStartOffset = this.getWindowSelection().getRangeAt(0).startOffset;

if (workingNodeContent && selectStartOffset >= 0) {
Expand Down
6 changes: 5 additions & 1 deletion src/TributeRange.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ class TributeRange {
}
}

convertNonWidthSpacesToRealOnes(text) {
return text.replace(/[\u200B-\u200D\uFEFF]/g, ' ')
}

getTextPrecedingCurrentSelection() {
let context = this.tribute.current,
text = ''
Expand All @@ -247,7 +251,7 @@ class TributeRange {
let selectedElem = this.getWindowSelection().anchorNode

if (selectedElem != null) {
let workingNodeContent = selectedElem.textContent
let workingNodeContent = this.convertNonWidthSpacesToRealOnes(selectedElem.textContent)
let selectStartOffset = this.getWindowSelection().getRangeAt(0).startOffset

if (workingNodeContent && selectStartOffset >= 0) {
Expand Down