feat: add missing translations for Gujarati, Kannada, and Marathi#692
feat: add missing translations for Gujarati, Kannada, and Marathi#692Muneerali199 wants to merge 12 commits intoAOSSIE-Org:devfrom
Conversation
…Marathi Added 61 translations across three Indian languages: - Gujarati (31): room search, management, and Whisper AI model strings - Kannada (15): room search and management strings - Marathi (15): room search and management strings All strings now properly localized in native scripts. Resolves user experience issues for non-English speakers in India. Closes AOSSIE-Org#688
…sue AOSSIE-Org#688) - Added 31 Gujarati translations (appPreferences, transcription models, search/hide room features) - Added 15 Kannada translations (search, hide room features) - Added 15 Marathi translations (search, hide room features) - Fixed ARB metadata formatting - Generated localization files via flutter gen-l10n - Total: 61 new translations added
|
🎉 Welcome @Muneerali199!
We appreciate your contribution! 🚀 |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
📝 WalkthroughWalkthroughUpdated localization resources for Gujarati, Kannada, and Marathi: added many Gujarati translation keys and Gujarati ARB entries, replaced detailed Changes
Sequence Diagram(s)(omitted — changes are translations and metadata updates only; no multi-component control-flow introduced) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
lib/l10n/app_gu.arblib/l10n/app_kn.arblib/l10n/app_localizations_gu.dartlib/l10n/app_localizations_kn.dartlib/l10n/app_localizations_mr.dartlib/l10n/app_mr.arbuntranslated.txt
🔇 Additional comments (3)
untranslated.txt (1)
1-22: LGTM! Untranslated strings significantly reduced.The untranslated keys for Gujarati, Kannada, and Marathi have been successfully reduced from 31, 15, and 15 respectively to just "clear" remaining for each locale. This aligns with the PR objectives to complete missing translations for these languages.
lib/l10n/app_localizations_mr.dart (1)
398-408: LGTM! Marathi translations appear well-formed.The Marathi translations use proper Devanagari script with correct Unicode encoding. The text appears readable and properly structured with appropriate use of matras (vowel marks).
Note: As per PR objectives, these should still be reviewed by a native Marathi speaker for accuracy and natural language flow.
Also applies to: 563-756, 1263-1267
lib/l10n/app_localizations_kn.dart (1)
398-408: LGTM! Kannada translations appear well-formed.The Kannada translations use proper Kannada script with correct Unicode encoding. The text appears readable and properly structured with appropriate use of vowel signs (gunithaksharas/ಗುಣಿತಾಕ್ಷರಗಳು).
Note: As per PR objectives, these should still be reviewed by a native Kannada speaker for accuracy and natural language flow.
Also applies to: 567-759, 1270-1274
- Fixed all 31 Gujarati translations with proper vowel marks - Resolved Unicode corruption issue from previous commit - Verified proper rendering with native Unicode characters
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @lib/l10n/app_gu.arb:
- Line 447: Replace Dart-interpolation style placeholders with ARB placeholders:
find the localization entries that use `${username}` (for example the key
"friendRequestAcceptedTo" and the other two similar entries flagged) and change
the placeholder syntax to `{username}` so the ARB file uses consistent
`{placeholder}` notation throughout.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
lib/l10n/app_gu.arblib/l10n/app_localizations_gu.dart
🚧 Files skipped from review as they are similar to previous changes (1)
- lib/l10n/app_localizations_gu.dart
🔇 Additional comments (4)
lib/l10n/app_gu.arb (4)
104-111: Unicode encoding issues resolved - excellent work!The critical Unicode encoding issues flagged in the previous review have been successfully fixed. The Gujarati text now includes proper matras (vowel marks) and conjuncts:
- "એપ પસંદગીઓ" (App Preferences) - correct
- "ટ્રાન્સક્રિપ્શન મોડેલ" (Transcription Model) - proper conjuncts
- Whisper model names properly formed
However, as per the PR acceptance criteria stating "all listed strings translated and reviewed by native speakers," please confirm that these translations have been reviewed by a native Gujarati speaker to ensure accuracy and natural phrasing.
112-134: Room search and management translations look good.The search and room management strings now display proper Gujarati Unicode with correct matras. The terminology is consistent:
- Hide/remove operations use "છુપાવો"
- Unhide operations use "દેખાડો"
- Search functionality properly translated
27-27: Metadata simplification is appropriate.The simplification of annotation blocks from detailed placeholder descriptions to
"description": "Metadata"is a valid refactoring that maintains ARB format compliance while fixing JSON formatting issues as noted in the PR summary.Also applies to: 176-176, 194-194, 216-216, 261-261, 265-265, 284-284, 298-298, 302-302, 333-333, 337-337, 341-341, 345-345, 349-349, 366-366, 373-373, 380-380, 384-384, 388-388, 392-392, 396-396, 436-436, 441-441, 449-449, 454-454, 460-460, 466-466
413-446: New feature translations look well-formed.The newly added translations for update functionality, friend requests, reporting, and live chapters all display proper Gujarati Unicode encoding. Technical terms like "Play Store", "AOSSIE", and "Resonate" are appropriately kept in English.
Ensure these translations have undergone native speaker review as specified in the PR acceptance criteria, particularly for natural phrasing in user-facing features like friend requests and error messages.
Also applies to: 462-487
lib/l10n/app_gu.arb
Outdated
| "friends": "મિત્રો", | ||
| "addFriend": "મિત્ર ઉમેરો", | ||
| "friendRequestAccepted": "મિત્ર વિનંતી સ્વીકારી", | ||
| "friendRequestAcceptedTo": "તમે હવે ${username} સાથે મિત્ર છો.", |
There was a problem hiding this comment.
Fix inconsistent placeholder syntax.
These lines use ${username} instead of {username}, which is inconsistent with the ARB format used throughout the rest of the file. ARB files should use {placeholder} syntax, not Dart string interpolation syntax ${placeholder}.
🔧 Proposed fix
- "friendRequestAcceptedTo": "તમે હવે ${username} સાથે મિત્ર છો.",
+ "friendRequestAcceptedTo": "તમે હવે {username} સાથે મિત્ર છો.",- "friendRequestDeclinedTo": "તમે ${username} ની મિત્ર વિનંતી નકારી છે.",
+ "friendRequestDeclinedTo": "તમે {username} ની મિત્ર વિનંતી નકારી છે.",- "callDeclinedTo": "યુઝર ${username} એ કૉલ નકારી છે.",
+ "callDeclinedTo": "યુઝર {username} એ કૉલ નકારી છે.",Also applies to: 452-452, 458-458
🤖 Prompt for AI Agents
In @lib/l10n/app_gu.arb at line 447, Replace Dart-interpolation style
placeholders with ARB placeholders: find the localization entries that use
`${username}` (for example the key "friendRequestAcceptedTo" and the other two
similar entries flagged) and change the placeholder syntax to `{username}` so
the ARB file uses consistent `{placeholder}` notation throughout.
- Removed duplicate entries (lines 533-555) - Kept better translations with improved wording - Fixed JSON structure
lib/l10n/app_gu.arb
Outdated
| "example": "true" | ||
| } | ||
| } | ||
| "description": "Metadata" |
There was a problem hiding this comment.
why is the description and everything else changed to "Metadata" ?
There was a problem hiding this comment.
Description changed to "metadata" everywhere again
There was a problem hiding this comment.
Description changed to "metadata"
|
hey @M4dhav you can check it i have restore the description |
M4dhav
left a comment
M4dhav
left a comment
There was a problem hiding this comment.
Old descriptions were better and included key metadata, please revert all changes unrelated to adding new strings
|
done sir @M4dhav |
|
Please fix merge conflicts |
|
I solve the conflict sir @M4dhav |
|
sir please @M4dhav let me know if further changes require for this |
3 participants
Description
This PR adds missing translations for Gujarati, Kannada, and Marathi languages as identified in issue #688. A total of 61 translations have been added across three languages to improve internationalization support.
Changes made:
Added 31 Gujarati translations (app preferences, transcription models, Whisper AI model variants, search rooms, hide/unhide room features)
Added 15 Kannada translations (search functionality, hide/unhide room features)
Added 15 Marathi translations (search functionality, hide/unhide room features)
Fixed ARB metadata formatting issues to ensure proper JSON structure
Generated localization dart files using flutter gen-l10n
Translation categories covered:
App preferences and settings
AI transcription models (Whisper variants: tiny, base, small, medium, large)
Room search functionality
Room hide/unhide features
Search error handling
Fixes #688
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
✅ Validated JSON syntax of all ARB files
✅ Successfully ran flutter gen-l10n to generate localization dart files
✅ Verified untranslated.txt shows significant reduction in missing translations for gu/kn/mr
✅ All ARB files follow proper metadata structure
✅ Translations use proper Unicode encoding
Test configuration:
Flutter SDK: 3.38.5
Dart SDK: 3.10.4
OS: Windows
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation (ARB files are properly formatted)
My changes generate no new warnings
I have checked my code and corrected any misspellings
Translations use proper Unicode characters for Gujarati, Kannada, and Marathi scripts
Maintainer Checklist
closes #688
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.