Skip to content

SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗#29

Merged
AdaInTheLab merged 1 commit intomasterfrom
fix/note-card-link
Jan 7, 2026
Merged

SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗#29
AdaInTheLab merged 1 commit intomasterfrom
fix/note-card-link

Conversation

@AdaInTheLab
Copy link
Owner

🧠 What & Why

This PR completes the end-to-end Lab Notes flow by making index cards link correctly to their synced, full-detail note pages while preserving locale awareness.

After Markdown notes are synced into the API, users can now reliably navigate from the Lab Notes registry to the rendered note content without losing language context.


🔁 What changed

  • Updated Lab Note card links to include the active locale prefix
  • Ensured index cards route to the correct detail view after sync
  • Preserved existing animations, hover states, and card styling
  • No changes to API behavior or data models

🌍 Locale behavior

  • Links now resolve to:
/{locale}/lab-notes/{slug}
  • Prevents accidental fallback to default language when browsing translated notes
  • Aligns Lab Notes navigation with the site’s existing i18n routing strategy

🧪 How to verify

  1. Navigate to the Lab Notes index in any locale (e.g. /ko/lab-notes)
  2. Click Open Note → on any card
  3. Confirm the detail page loads:
  • correct note
  • correct locale
  1. Use Back to Lab Notes to return to the same locale registry

🛡 Scope & guardrails

  • UI-only change
  • No schema or endpoint changes
  • No breaking route behavior
  • Safe to deploy independently

🗒 Notes

This PR intentionally focuses on navigation correctness rather than routing refactors.
Future cleanups (e.g. param name consolidation) can be handled separately without affecting behavior.

- Prefix Lab Note links with active i18n locale
- Ensure index cards route to synced note detail pages
- Preserve existing Lab Note detail loading and fallback behavior

co-authored-by: Lyric <lyric@thehumanpatternlab.com>
co-authored-by: Carmel <carmel@thehumanpatternlab.com>
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

😼🔥 Carmel Chaos Stamp™

🔥 Carmel Chaos Stamp™
😼🔥💬 "I sense nonsense. Proceed."

PR: #29SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗
Author: @AdaInTheLab

This automated judgment has been issued by the Chief Judgment Office (CJO).

@AdaInTheLab AdaInTheLab merged commit 0ba4735 into master Jan 7, 2026
3 checks passed
@AdaInTheLab AdaInTheLab deleted the fix/note-card-link branch January 7, 2026 01:04
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants