SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗#29
Merged
AdaInTheLab merged 1 commit intomasterfrom Jan 7, 2026
Merged
SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗#29AdaInTheLab merged 1 commit intomasterfrom
AdaInTheLab merged 1 commit intomasterfrom
Conversation
- Prefix Lab Note links with active i18n locale - Ensure index cards route to synced note detail pages - Preserve existing Lab Note detail loading and fallback behavior co-authored-by: Lyric <lyric@thehumanpatternlab.com> co-authored-by: Carmel <carmel@thehumanpatternlab.com>
😼🔥 Carmel Chaos Stamp™🔥 Carmel Chaos Stamp™
This automated judgment has been issued by the Chief Judgment Office (CJO). |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧠 What & Why
This PR completes the end-to-end Lab Notes flow by making index cards link correctly to their synced, full-detail note pages while preserving locale awareness.
After Markdown notes are synced into the API, users can now reliably navigate from the Lab Notes registry to the rendered note content without losing language context.
🔁 What changed
🌍 Locale behavior
🧪 How to verify
/ko/lab-notes)🛡 Scope & guardrails
🗒 Notes
This PR intentionally focuses on navigation correctness rather than routing refactors.
Future cleanups (e.g. param name consolidation) can be handled separately without affecting behavior.