Skip to content

Intercom not initialized crash #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaravgarg wants to merge 2 commits into from
+20 −7
Closed

Intercom not initialized crash #4542

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87674da
fix: guard Intercom calls with initialization flag
aaravgarg Feb 1, 2026
80c64e6
fix: handle _initialized flag for all code paths in initIntercom
aaravgarg Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/lib/utils/analytics/intercom.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,31 @@ class IntercomManager {
static IntercomManager get instance => _instance;
static final SharedPreferencesUtil _preferences = SharedPreferencesUtil();

bool _initialized = false;

IntercomManager._internal();

Intercom get intercom => Intercom.instance;
bool get _isIntercomEnabled =>
PlatformService.isIntercomSupported && (Env.intercomAppId != null && Env.intercomAppId!.isNotEmpty);
_initialized &&
PlatformService.isIntercomSupported &&
(Env.intercomAppId != null && Env.intercomAppId!.isNotEmpty);
Comment on lines 19 to +22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To improve readability and avoid duplicating logic, consider extracting the condition for whether Intercom is configured into its own private getter. This condition is used here and also in initIntercom.

  bool get _isIntercomConfigured =>
      PlatformService.isIntercomSupported &&
      (Env.intercomAppId != null && Env.intercomAppId!.isNotEmpty);

  bool get _isIntercomEnabled => _initialized && _isIntercomConfigured;

You would then also use _isIntercomConfigured inside initIntercom.


factory IntercomManager() {
return _instance;
}

Future<void> initIntercom() async {
if (Env.intercomAppId == null) return;
return PlatformService.executeIfSupportedAsync(
_isIntercomEnabled,
await PlatformService.executeIfSupportedAsync(
PlatformService.isIntercomSupported && (Env.intercomAppId != null && Env.intercomAppId!.isNotEmpty),
() => intercom.initialize(
Env.intercomAppId!,
iosApiKey: Env.intercomIOSApiKey,
androidApiKey: Env.intercomAndroidApiKey,
),
);
_initialized = true;
}
Comment on lines 28 to 47
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The early return on line 29 if Env.intercomAppId is null prevents _initialized from ever being set to true. This leaves the IntercomManager in a perpetual 'initializing' state, which is incorrect as the initialization process has completed (by doing nothing).

The check for Env.intercomAppId != null on line 31 is sufficient. By removing the early return, _initialized will be correctly set to true after the initialization attempt, and _isIntercomEnabled will correctly evaluate to false if Intercom is not configured, preventing any calls.

  Future<void> initIntercom() async {
    await PlatformService.executeIfSupportedAsync(
      PlatformService.isIntercomSupported && (Env.intercomAppId != null && Env.intercomAppId!.isNotEmpty),
      () => intercom.initialize(
        Env.intercomAppId!,
        iosApiKey: Env.intercomIOSApiKey,
        androidApiKey: Env.intercomAndroidApiKey,
      ),
    );
    _initialized = true;
  }


Future displayChargingArticle(String device) async {
Expand Down