Skip to content

Comments

UHF-10235: Added a check that the content has loaded before scrolling to results to fix issue on screen reader and safari#1176

Merged
annadruid merged 3 commits intomainfrom
UHF-10235
Feb 6, 2025
Merged

UHF-10235: Added a check that the content has loaded before scrolling to results to fix issue on screen reader and safari#1176
annadruid merged 3 commits intomainfrom
UHF-10235

Conversation

@annadruid
Copy link
Contributor

@annadruid annadruid commented Feb 5, 2025

UHF-10235

What was done

  • Safari had an issue where the screen reader would read the previous vacant jobs and job listings when the focus was moved, this was fixed with adding a check that the content has loaded

How to install

  • Make sure your Rekry instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10235
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1176/html_report/

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1176/html_report/

@github-actions
Copy link

github-actions bot commented Feb 6, 2025

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1176/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue 🦖

@annadruid annadruid merged commit edd2f84 into main Feb 6, 2025
2 checks passed
@annadruid annadruid deleted the UHF-10235 branch February 6, 2025 15:40
@teroelonen teroelonen changed the title UHF-10235: Added small delay to scroll to results to fix issue on screen reader and safari UHF-10235: Added a check that the content has loaded before scrolling to results to fix issue on screen reader and safari Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants