Skip to content

UHF-10235: Added a check that the content has loaded before scrolling to results to fix issue on screen reader and safari #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annadruid merged 3 commits into from
Feb 6, 2025
Merged

UHF-10235: Added a check that the content has loaded before scrolling to results to fix issue on screen reader and safari #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4108e8d
UHF-10235: Added small delay to scroll to results to fix issue on scr…
annadruid Feb 5, 2025
2edd11a
UHF-10235: Changed how scroll is called in job listing search results…
annadruid Feb 5, 2025
49f2833
UHF-10235: Removed unnecessary spaces
annadruid Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/job-search.min.js
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 5 additions & 4 deletions src/js/react/apps/job-search/containers/ResultsContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,17 @@ const ResultsContainer = () => {
const scrollTarget = createRef<HTMLDivElement>();
const { query, promoted, handleResults } = useResultsQuery(urlParams);

// Scroll to results when they change.
const choices = Boolean(Object.keys(urlParams).length);
useScrollToResults(scrollTarget, choices);

const { data, error, isLoading, isValidating } = useIndexQuery({
keepPreviousData: true,
query,
multi: promoted
});

// Scroll to results when they change.
const choices = Boolean(Object.keys(urlParams).length);
const shouldScrollOnRender = Boolean(choices && !isLoading && !isValidating);
useScrollToResults(scrollTarget, shouldScrollOnRender);

const updatePage = (e: SyntheticEvent<HTMLButtonElement>, index: number) => {
e.preventDefault();
setPage(index.toString());
Expand Down
Loading