Skip to content

Comments

UHF-11329 Chart refactor#899

Merged
khalima merged 7 commits intomainfrom
UHF-11329
Feb 6, 2025
Merged

UHF-11329 Chart refactor#899
khalima merged 7 commits intomainfrom
UHF-11329

Conversation

@khalima
Copy link
Contributor

@khalima khalima commented Feb 5, 2025

UHF-11329

What was done

  • Added HelfiChart bundle class and applied it to the helfi_media_chart.
  • Removed obsolete chart-iframe template.
  • Removed cookie category custom functionality in favour of embedded-content-cookie-compliance.js.
  • Added test for the HelfiChart.
  • Configure HDBT cookie banner module when test content module is being installed.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11329 drupal/hdbt:dev-UHF-11329
  • Run make drush-updb drush-cr

How to test

  • Check that the chart works as before.
  • Check that code follows our standards

Other PRs

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants