Merged
Conversation
Refs: PL-214
|
|
PALVELUKARTTA-API branch is deployed to platta: https://palvelukartta-api-pr373.dev.hel.ninja 🚀🚀🚀 |
voneiden
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
A notable (10x) performance improvement in low load conditions in test environment can be observed:
queryset = queryset.filter(service_nodes__in=[1,2,3,4,5]).distinct()Planning Time: 0.835 ms
Execution Time: 51.425 ms
vs
matching_unit_ids = Unit.objects.filter(service_nodes__in=[1,2,3,4,5]).values("id")
queryset = queryset.filter(id__in=Subquery(matching_unit_ids))Planning Time: 0.444 ms
Execution Time: 5.983 ms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize unit filtering queries by using
Subqueryinstead ofdistinct()-calls.Context
PL-214
How Has This Been Tested?
Via new unit-tests.