refactor: 💡 reconcile file and multiple file upload#804
refactor: 💡 reconcile file and multiple file upload#804
Conversation
… upload and multi file upload
refactor: 💡 create hook for drag and drop
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9a79822 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@clickhouse/click-ui': minor | |||
There was a problem hiding this comment.
can all the existing components still be used the same way? Or is this a breaking change?
|
|
||
| const ProgressBarWrapper = styled.div` | ||
| margin-top: ${({ theme }) => theme.click.fileUpload.md.space.gap}; | ||
| margin-bottom: 9px; |
There was a problem hiding this comment.
There's a lot of custom sizing in here.
There was a problem hiding this comment.
@gjones that's the original author's source code, see latest/main (at time of writing), e.g. here
The task here is just the reconciliation; it's not attempting to change any styles unless moved or necessary tweaks are made to migrate to shared parts.
That can be modified, but that's separate from the goal in this PR.
3 participants
Why?
Reconcile FileUpload and FileMultiUpload to prevent and reduce concurrent implementations, e.g. behaviour, features, styles, etc.
In the previous version, the multiple-file-upload component recreated the file upload in its file context, which was prone to errors.
How?
Preview?
demo-shared-file-upload-multi-upload.mov