-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: 💡 reconcile file and multiple file upload #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5a5a9a2
refactor: 💡 make FileUploadArea, a reusable file upload area for file…
punkbit e6bc29c
refactor: 💡 make FileUploadItem to share between file upload and mult…
punkbit 5626d01
refactor: 💡 create hook for drag and drop
punkbit aa59f4a
refactor: 💡 export FileUpload and FileMultiUpload
punkbit d1d2af6
chore: 🤖 format
punkbit 5206955
chore: 🤖 add changeset
punkbit e81ffa4
fix: 🐛 is error
punkbit 9a79822
chore: 🤖 update changeset
punkbit 6087ab9
fix: 🐛 typo
punkbit f639a35
Merge branch 'main' into refactor/file-multiple-upload-use-file-upload
punkbit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clickhouse/click-ui': minor | ||
| --- | ||
|
|
||
| Reconcile FileUpload and FileMultiUpload to prevent and reduce concurrent implementations, e.g. behaviour, features, styles, etc. In the previous version, the multiple file upload component was recreating the file upload in its file context which is prone to mistakes and hard to maintain. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.