refactor: improve auth types

[Sim-sat]

Description

The recent bug was only possible because there were two identical functions with different names and one of them didn't use types. I removed the functions and created an interface for the Oidc login params. This makes the code little bit easier to read and less error prone.
I also deleted the .eslintignore since it's deprecated.

[gemini-code-assist]

Summary of Changes

Hello @Sim-sat, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the authentication module to improve type safety, reduce code redundancy, and simplify OIDC (OpenID Connect) login parameter handling. By introducing a dedicated interface for OIDC login parameters and removing obsolete functions, the changes aim to make the authentication code more robust, easier to maintain, and less prone to errors. Additionally, it cleans up the project's ESLint configuration by removing a deprecated ignore file.

Highlights

• Improved Type Safety: Introduced an OidcLoginParams interface to strongly type the parameters for initiateOidcLogin, enhancing code reliability and readability.
• Removed Redundant Functions: Eliminated getOidcProviders and checkOidcAvailability functions, streamlining the authentication API and reducing duplicate logic.
• Simplified OIDC Provider Handling: Updated the Auth page and useAuth hook to directly access OIDC provider information from loginSettings, removing an unnecessary query.
• ESLint Configuration Cleanup: Removed the deprecated .eslintignore file.

Changelog

• SparkyFitnessFrontend/.eslintignore
  • Removed the deprecated ESLint ignore file.
• SparkyFitnessFrontend/src/api/Auth/auth.ts
  • Defined OidcLoginParams interface for initiateOidcLogin parameters.
  • Modified initiateOidcLogin to accept and destructure OidcLoginParams.
  • Deleted getOidcProviders and checkOidcAvailability functions.
• SparkyFitnessFrontend/src/hooks/Auth/useAuth.ts
  • Removed import and usage of getOidcProviders.
  • Removed the useOidcProvidersQuery hook.
  • Updated useInitiateOidcLoginMutation to align with the new initiateOidcLogin signature.
• SparkyFitnessFrontend/src/pages/Auth/Auth.tsx
  • Removed import and usage of useOidcProvidersQuery.
  • Adjusted OIDC provider rendering and auto-redirect logic to directly use loginSettings.oidc.providers.
  • Removed a redundant dark:bg-gray- CSS class from a Card component.

Activity

• The pull request was created by Sim-sat, initiating the proposed changes to the authentication module.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a solid refactoring effort that improves the authentication-related code by introducing better typing for OIDC login parameters and consolidating logic by removing a redundant function. This successfully addresses the bug mentioned in the description and makes the code more maintainable. I've found one critical issue where a variable is used incorrectly after the refactoring, which would lead to a runtime error. Please see the detailed comment.

[Sim-sat]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a great improvement. It refactors the OIDC login flow to use a typed interface for parameters, which makes the code more readable and less error-prone. The removal of the redundant getOidcProviders function and useOidcProvidersQuery hook cleans up the codebase and centralizes the logic for fetching authentication settings. The simplification of useInitiateOidcLoginMutation is also a nice touch. Furthermore, the PR fixes a bug in the auto-redirect logic and removes a deprecated .eslintignore file. The changes are well-executed and improve the overall quality of the code.