refactor: improve auth types

SparkyFitnessFrontend/src/api/Auth/auth.ts

@@ -111,10 +111,14 @@ export const logoutUser = async (): Promise<void> => {
   window.location.href = '/';
 };
 
-export const initiateOidcLogin = async (
-  providerId: string,
-  requestSignUp: boolean = false
-) => {
+export interface OidcLoginParams {
+  providerId: string;
+  requestSignUp?: boolean;
+}
+export const initiateOidcLogin = async ({
+  providerId,
+  requestSignUp = false,
+}: OidcLoginParams) => {
   await authClient.signIn.sso({
     providerId: providerId,
     callbackURL: window.location.origin,
@@ -123,19 +127,6 @@ export const initiateOidcLogin = async (
   });
 };
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export const getOidcProviders = async (): Promise<any[]> => {
-  const response = await fetch('/api/auth/settings');
-  if (!response.ok) return [];
-  const data = await response.json();
-  return data.oidc?.providers || [];
-};
-
-export const checkOidcAvailability = async (): Promise<boolean> => {
-  const providers = await getOidcProviders();
-  return providers.length > 0;
-};
-
 export const getLoginSettings = async (): Promise<LoginSettings> => {
   const response = await fetch('/api/auth/settings');
   if (!response.ok) {

SparkyFitnessFrontend/src/hooks/Auth/useAuth.ts

@@ -6,7 +6,6 @@ import {
   loginUser,
   verifyMagicLink,
   getLoginSettings,
-  getOidcProviders,
   initiateOidcLogin,
   resetPassword,
   requestPasswordReset,
@@ -96,24 +95,10 @@ export const useAuthSettings = () => {
   });
 };
 
-export const useOidcProvidersQuery = (enabled: boolean) => {
-  return useQuery({
-    queryKey: authKeys.oidcProviders,
-    queryFn: getOidcProviders,
-    enabled: enabled,
-  });
-};
-
 export const useInitiateOidcLoginMutation = () => {
   const { t } = useTranslation();
   return useMutation({
-    mutationFn: ({
-      providerId,
-      requestSignUp = false,
-    }: {
-      providerId: string;
-      requestSignUp?: boolean;
-    }) => initiateOidcLogin(providerId, requestSignUp),
+    mutationFn: initiateOidcLogin,
     meta: {
       // Kein Success-Message nötig, da Redirect erfolgt
       errorMessage: t('auth.oidcError', 'Failed to initiate provider login.'),

SparkyFitnessFrontend/src/pages/Auth/Auth.tsx

@@ -27,7 +27,6 @@ import {
   useAuthSettings,
   useInitiateOidcLoginMutation,
   useLoginUserMutation,
-  useOidcProvidersQuery,
   useRegisterUserMutation,
   useRequestMagicLinkMutation,
   useVerifyMagicLinkMutation,
@@ -58,9 +57,6 @@ const Auth = () => {
 
   const queryClient = useQueryClient();
   const { data: loginSettings } = useAuthSettings();
-  const { data: oidcProviders } = useOidcProvidersQuery(
-    !!loginSettings?.oidc?.enabled
-  );
   const { mutateAsync: loginUser } = useLoginUserMutation();
   const { mutateAsync: registerUser } = useRegisterUserMutation();
   const { mutateAsync: requestMagicLink } = useRequestMagicLinkMutation();
@@ -80,28 +76,23 @@ const Auth = () => {
       try {
         if (
           loginSettings &&
-          oidcProviders.length === 1 &&
+          loginSettings.oidc.providers.length === 1 &&
           loginSettings.oidc.enabled
         ) {
-          const providers = oidcProviders[0];
+          const provider = loginSettings.oidc.providers[0];
 
           // AUTO-REDIRECT LOGIC: Only when email is disabled and exactly 1 OIDC provider is active
-          if (
-            !loginSettings.email.enabled &&
-            providers.length === 1 &&
-            !authUser &&
-            !authLoading
-          ) {
+          if (!loginSettings.email.enabled && !authUser && !authLoading) {
             console.log(
               'Auth Page: Auto-redirecting to OIDC provider:',
-              providers[0].id
+              provider.id
             );
             // Safety timeout to catch any late-arriving sessions
             const timer = setTimeout(() => {
               if (!authUser) {
                 initiateOidcLogin({
-                  providerId: providers[0].id,
-                  requestSignUp: providers[0].auto_register,
+                  providerId: provider.id,
+                  requestSignUp: provider.auto_register,
                 });
               }
             }, 800);
@@ -118,7 +109,7 @@ const Auth = () => {
     };
     fetchAuthSettings();
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [loggingLevel, authUser, authLoading, navigate]);
+  }, [loggingLevel, authUser, authLoading, navigate, loginSettings]);
 
   // Passkey Conditional UI (Autofill)
   useEffect(() => {
@@ -476,7 +467,7 @@ const Auth = () => {
         ) : showMfaChallenge ? (
           <MfaChallenge {...mfaChallengeProps} />
         ) : (
-          <Card className="w-full max-w-md dark:bg-gray-">
+          <Card className="w-full max-w-md">
             <CardHeader className="text-center">
               <div className="flex items-center justify-center mb-4">
                 <img
@@ -607,7 +598,7 @@ const Auth = () => {
                     </Button>
                     {loginSettings?.oidc.enabled && (
                       <>
-                        {oidcProviders?.map((provider) => (
+                        {loginSettings.oidc.providers?.map((provider) => (
                           <Button
                             key={provider.id}
                             variant="outline"
@@ -710,8 +701,9 @@ const Auth = () => {
                 </Tabs>
               ) : (
                 <div>
-                  {loginSettings?.oidc.enabled && oidcProviders?.length > 0 ? (
-                    oidcProviders.map((provider) => (
+                  {loginSettings?.oidc.enabled &&
+                  loginSettings.oidc.providers?.length > 0 ? (
+                    loginSettings.oidc.providers.map((provider) => (
                       <Button
                         key={provider.id}
                         variant="outline"