fix: Enable private field access in UpdateComponentTool#106
Open
CharlieHess wants to merge 1 commit intoCoderGamester:mainfrom
Open
fix: Enable private field access in UpdateComponentTool#106CharlieHess wants to merge 1 commit intoCoderGamester:mainfrom
CharlieHess wants to merge 1 commit intoCoderGamester:mainfrom
Conversation
Use SerializedObject API as primary method for modifying component fields, with enhanced reflection as fallback. This fixes three issues: 1. Private fields in base classes now accessible (recursive type search) 2. Asset references can be set by path or GUID 3. Nested field paths supported via SerializedObject.FindProperty() Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
This is admittedly a Cursor / Opus collaboration but for verification I'm able to wire up event listeners now, using my fork, and prior to that I was stuck on these! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
update_componenttool fails when trying to modify:_eventReference._eventare unsupportedRoot cause:
GetField()only searches the immediate type, and the existingUnityEngine.Objecthandler doesn't load assets.Solution
Hybrid approach using SerializedObject API as primary, with enhanced reflection as fallback:
SerializedObject.FindProperty()automatically handles base class fields and nested pathsGetFieldRecursive()/GetPropertyRecursive()helpers traverse the type hierarchy for non-serialized propertiesSetSerializedPropertyValue()handles allSerializedPropertyTypecases includingObjectReferencewith asset path/GUID supportConvertJTokenToValue()updated to load assets by path (Assets/...), GUID ({guid: "..."}), or name searchUsage Examples