chore(doc): doocument tracer.ContextWithSpan panic #4313
Open
chore(doc): doocument tracer.ContextWithSpan panic #4313
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
igoragoli
approved these changes
Dec 24, 2025
kakkoyun
reviewed
Jan 5, 2026
|
|
||
| // ContextWithSpan returns a copy of the given context which includes the span s. | ||
| // | ||
| // ctx must be non-nil. If ctx is nil, context.WithValue panics, "cannot create context from nil parent". |
Member
There was a problem hiding this comment.
Since this already panics, shall we add an explicit hard assertion (panic) that could make it easier to explain.
Member
Author
There was a problem hiding this comment.
@kakkoyun what kind of assertion are you expecting ? A unit test ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve documentation of the
tracer.ContextWithSpanfunction in charge of adding aSpanto acontext.ContextMotivation
We spent nearly an hour with @igoragoli debugging a future contrib that was not showing this panic properly.
Having clear documentation over a function that can cause a panic is always nice.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!