Skip to content

chore(doc): doocument tracer.ContextWithSpan panic #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genesor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(doc): doocument tracer.ContextWithSpan panic #4313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ddtrace/tracer/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import (
)

// ContextWithSpan returns a copy of the given context which includes the span s.
//
// ctx must be non-nil. If ctx is nil, context.WithValue panics, "cannot create context from nil parent".
Copy link
Member

@kakkoyun kakkoyun Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this already panics, shall we add an explicit hard assertion (panic) that could make it easier to explain.

Copy link
Member Author

@genesor genesor Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakkoyun what kind of assertion are you expecting ? A unit test ?

func ContextWithSpan(ctx context.Context, s *Span) context.Context {
newCtx := orchestrion.CtxWithValue(ctx, internal.ActiveSpanKey, s)
return contextWithPropagatedLLMSpan(newCtx, s)
Expand Down
Loading