adding uptime-checks-workload.v1.json#699
adding uptime-checks-workload.v1.json#699nikitajainn-google wants to merge 14 commits intoGoogleCloudPlatform:masterfrom
Conversation
nikitajainn-google
changed the title
| "displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure" | ||
| "documentation": {}, | ||
| "userLabels": { | ||
| "workload_name": "${WORKLOAD_NAME}", |
There was a problem hiding this comment.
If we want to match all the environment variables set from the Workload Details Observability tab
workload_type = gke_deployment
location = ${LOCATION}
project_id = ${PROJECT_ID}
namespace = ${NAMESPACE}
There was a problem hiding this comment.
not sure if i'm missing something, where are these user labels getting populated in the workload details tab?
| @@ -0,0 +1,37 @@ | |||
| { | |||
| "displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure" | |||
There was a problem hiding this comment.
I think this is fine for now but note we can technically support uptime checks for ingress via URL, so we may want to consider passing in the "Load Balancer" part of the display name
| "perSeriesAligner": "ALIGN_NEXT_OLDER", | ||
| "crossSeriesReducer": "REDUCE_COUNT_FALSE", | ||
| "groupByFields": [ | ||
| "resource.label.*" |
There was a problem hiding this comment.
Our current alert policy lists these out, but if we want to support ingress + load balancer through the same policy template then I think this is fine
| "cluster": "${CLUSTER_NAME}", | ||
| "uptime_check_id": "${UPTIME_CHECK_ID}", | ||
| }, | ||
| "conditions": [ |
There was a problem hiding this comment.
Missing conditions.displayName -> "Failure of ${alertPolicy.displayName}"
There was a problem hiding this comment.
not sure how we'll populate the alert policy display name, i think it would make sense to put the uptime check name here?
3 participants
No description provided.