-
Notifications
You must be signed in to change notification settings - Fork 343
adding uptime-checks-workload.v1.json #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 5 commits
d930a73
f8119a7
0806a56
dbe09bd
22a1953
7d16209
3a98f25
84a7696
ad2897a
f313af5
f02a58f
1e73e9e
d7e16a0
9c20196
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| { | ||
| "displayName": "${CLUSTER_NAME}/${WORKLOAD_NAME} GKE Load Balancer Check uptime failure" | ||
| "documentation": {}, | ||
| "userLabels": { | ||
| "workload_name": "${WORKLOAD_NAME}", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we want to match all the environment variables set from the Workload Details Observability tab workload_type = gke_deployment
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if i'm missing something, where are these user labels getting populated in the workload details tab? |
||
| "cluster": "${CLUSTER_NAME}", | ||
| "uptime_check_id": "${UPTIME_CHECK_ID}", | ||
| }, | ||
| "conditions": [ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing conditions.displayName -> "Failure of ${alertPolicy.displayName}"
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure how we'll populate the alert policy display name, i think it would make sense to put the uptime check name here? |
||
| { | ||
| "conditionThreshold": { | ||
| "aggregations": [ | ||
| { | ||
| "alignmentPeriod": "1200s", | ||
| "perSeriesAligner": "ALIGN_NEXT_OLDER", | ||
| "crossSeriesReducer": "REDUCE_COUNT_FALSE", | ||
| "groupByFields": [ | ||
| "resource.label.*" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Our current alert policy lists these out, but if we want to support ingress + load balancer through the same policy template then I think this is fine |
||
| ], | ||
| } | ||
| ], | ||
| "comparison": "COMPARISON_GT", | ||
| "duration": "${UPTIME_DURATION}", | ||
| "filter": "metric.type=\"monitoring.googleapis.com/uptime_check/check_passed\" AND metric.label.check_id=\"${UPTIME_CHECK_ID}\" AND resource.type=\"k8s_service\"", | ||
nikitajainn-google marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "thresholdValue": 1, | ||
| "trigger": { | ||
| "count": 1 | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "alertStrategy": { | ||
| "autoClose": "604800s" | ||
| }, | ||
| "combiner": "OR", | ||
| "enabled": true, | ||
nikitajainn-google marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now but note we can technically support uptime checks for ingress via URL, so we may want to consider passing in the "Load Balancer" part of the display name