Small fixes for options & localStorage#33
Draft
murhum1 wants to merge 1 commit intoJohn-Paul-R:masterfrom
Draft
Conversation
…ursor; remove debounce on localStorage saves, as it is fast anyway
Owner
|
I think making the whole I'll look into possible reasons for the debounce bug on Firefox. Thanks for the fixes! I will merge after the small |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option sliders weren't working on Firefox and I was only able to change options by clicking outside the sliders themselves, which seemed a bit silly. PR should fix this and only allow changing options by clicking on the slider itself, instead of the whole
<li>element. If desired, could instead make the whole<li>element havecursor: pointercss. Tested to work on Firefox and Chrome.Also removed debouncing on localStorage saves, as it's fast anyway and shouldn't need to be debounced. The debounce function from util.js also didn't seem to work on Firefox, while it worked fine on Chrome for some reason, but I didn't check any further.