Skip to content

Small fixes for options & localStorage #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
murhum1 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Small fixes for options & localStorage #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 16 additions & 23 deletions js/pixi_atlas_of_worlds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,10 +1044,9 @@ class HTMLElement{
}
}
const DISPLAY_OPTIONS_STORAGE_KEY = 'displayOptions';
function storeDisplayOptions() { debounce(
() => { window.localStorage.setItem(DISPLAY_OPTIONS_STORAGE_KEY, JSON.stringify(options)); }
, 1500
)};
function storeDisplayOptions() {
window.localStorage.setItem(DISPLAY_OPTIONS_STORAGE_KEY, JSON.stringify(options));
}
class Option {
constructor(name, key) {
this.name = name;
Expand All @@ -1065,7 +1064,7 @@ const DEFAULT_OPTIONS = {
MasterWatchstone: true,
nodeScaleFactor: 1
};
const DEFAULT_OPTIONS_LIST = [
const OPTIONS_LIST = [
new Option("Show Lines", "drawLines"),
new Option("Show Nodes", "drawNodes"),
new Option("Show Names", "drawNames"),
Expand Down Expand Up @@ -1156,11 +1155,11 @@ function createOptionsMenu() {
const optionsList = document.createElement('ul');
optionsList.id = "options_list";
// Generate dropdown elements for each option
for (let opt of DEFAULT_OPTIONS_LIST) {
for (let opt of OPTIONS_LIST) {
const key = opt.key;
const elem = options[opt.key];
let div = document.createElement('div');
let lstElement = new HTMLElement('li');
const div = document.createElement('div');
const lstElement = new HTMLElement('li');
lstElement.innerHTML = "<p>"+opt.name+"</p>\n";
if (typeof(elem)=="boolean") {
if (elem) {
Expand All @@ -1173,18 +1172,13 @@ function createOptionsMenu() {
}
div.innerHTML = lstElement.asString();

let domElement = div.firstChild;
let input = domElement.getElementsByTagName('input')[0];
const domElement = div.firstChild;
const input = domElement.getElementsByTagName('input')[0];
if (input.type==="checkbox") {
domElement.addEventListener('click', (e)=>{
// input.checked = !input.checked;
e.stopPropagation();
if (e.detail > 0){
setOption(key, !options[key]);
} else { //This somehow fixes a visual bug that caused checkbox display to be inverted when you click the slider. IDK - JP
input.checked = !input.checked;
}

const slider = domElement.getElementsByClassName('slider')[0];
slider.addEventListener('click', (e)=>{
e.preventDefault();
setOption(key, !options[key]);
});
} else if (input.type==='text') {
domElement.addEventListener('input', (e)=>{
Expand Down Expand Up @@ -1251,10 +1245,9 @@ export var renderStageThrottled = throttle(
);

const REGION_TIER_STORAGE_KEY = 'regionTiers';
const storeRegionTiers = debounce(
() => { window.localStorage.setItem(REGION_TIER_STORAGE_KEY, JSON.stringify(regionTiers)); },
1500
);
function storeRegionTiers() {
window.localStorage.setItem(REGION_TIER_STORAGE_KEY, JSON.stringify(regionTiers));
}

function loadRegionTiers() {
let stored = JSON.parse(window.localStorage.getItem(REGION_TIER_STORAGE_KEY));
Expand Down