Support new AbstractFFTs.AdjointStyle trait for FFT and DCT plans#249
Support new AbstractFFTs.AdjointStyle trait for FFT and DCT plans#249stevengj merged 8 commits intoJuliaMath:masterfrom
Conversation
|
@gaurav-arya where is |
|
I think you can remove that: it was one attempt at reusing AbstractFFTs' tests here but we haven't yet agreed on a good solution, see JuliaMath/AbstractFFTs.jl#78. If you'd like to push this through perhaps if you can think of a minimal self contained test here to test the traits, we could sidestep the problem and get this merged (note I don't have merge rights, so ultimately the decision should be verified with someone who does). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 70.99% 73.08% +2.08%
==========================================
Files 5 5
Lines 531 535 +4
==========================================
+ Hits 377 391 +14
+ Misses 154 144 -10
☔ View full report in Codecov by Sentry. |
|
This is ready! |
|
Bump |
|
LGTM. |
|
@stevengj could FFTW get a release for this PR? It would be helpful for including FFTW's run of the test suite in downstream tests for JuliaMath/AbstractFFTs.jl#118 |
Supports the new
AbstractFFTs.AdjointStyletrait.This is a draft PR because JuliaMath/AbstractFFTs.jl#78 and JuliaMath/AbstractFFTs.jl#109 are not merged yet, which this PR relies on.