Skip to content

nixos/pretalx: Add support for secrets#486936

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/pretalx-secrets
Feb 4, 2026
Merged

nixos/pretalx: Add support for secrets#486936
mweinelt merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/pretalx-secrets

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Feb 4, 2026

Pretty much all settings can be set by env variables

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@dasJ dasJ requested review from 0x4A6F and mweinelt February 4, 2026 14:34
@dasJ dasJ added the backport release-25.11 Backport PR automatically label Feb 4, 2026
@dasJ dasJ force-pushed the feat/pretalx-secrets branch from 55a1d17 to 52e1277 Compare February 4, 2026 14:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 4, 2026
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More hints and slightly more aligned with what we already have for pretix.

Is this tested? In particular I wonder if the secrets are required for pretalx-admin.

};

environmentFiles = lib.mkOption {
description = "Environment files to load into pretalx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "Environment files to load into pretalx";
description = ''
Environment files that allow passing secret configuration values.
Each line must follow the `PRETALX_SECTION_KEY=value` pattern.
'';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is currently running. For the CLI tool, it was necessary for me to test the SMTP connection ;)

Pretty much all settings can be set by env variables
@dasJ dasJ force-pushed the feat/pretalx-secrets branch from 52e1277 to 188bcbd Compare February 4, 2026 15:08
@mweinelt mweinelt added this pull request to the merge queue Feb 4, 2026
Merged via the queue into NixOS:master with commit f652180 Feb 4, 2026
27 of 31 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 4, 2026

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Feb 4, 2026
@dasJ dasJ deleted the feat/pretalx-secrets branch February 4, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants