[IMP][16.0] project_sequence: set analytic's code as per project's sequence_code#1658
Open
arnaudlayec wants to merge 3 commits intoOCA:16.0from
Open
[IMP][16.0] project_sequence: set analytic's code as per project's sequence_code#1658arnaudlayec wants to merge 3 commits intoOCA:16.0from
code as per project's sequence_code#1658arnaudlayec wants to merge 3 commits intoOCA:16.0from
Conversation
Contributor
|
Hi @anddago78, @yajo, |
yajo
reviewed
Jan 20, 2026
Member
yajo
left a comment
There was a problem hiding this comment.
Please could you share screenshots or screencast to see how it was before and how it is now? I think that will make it easier to review.
Code looks OK. Just one doubt.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Before, the project's
display_namewas synched in the project's analytic account (aac) name. This way, the "code" field of aac was empty, and the name had both the project's code and the name in the default format "[code] - [name]" Proposal : synch the 2 fields ("sequence_code" and "name") of the project respectively in the 2 fields ("code" and "name") of the aacThis allow:
display_namemethod)analytic_distributionusing the aac's codeThis PR also update tests.
I needed to fix some:
default_plan_idmust be computed once to existtest_project_without_sequenceandtest_project_with_empty_sequence. Doing that required to change project'screatemethodNote: if OK, I can port to upper version.