Ensure Forest Boss Key dummy chest is gilded if correct_chest_appearances is off#2480
Merged
fenhl merged 2 commits intoOoTRandomizer:Devfrom Oct 25, 2025
Merged
Conversation
GSKirox
added
Type: Bug
SlyryD
reviewed
Oct 25, 2025
SlyryD
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2463
If correct_chest_appearances is set to Off, then the dummy chest actor in Forest twisted hallway room that was added back in #1806 to make it match content will never set the color and size in get_chest_override.
So it defaults to type 0, which is a big brown chest. Which is different from the vanilla game where it shows a fake gilded chest instead.
In that case, when initializing our dummy chest actor, we can put its type directly at Gold chest.
If any CAMC setting is on, it will be overwritten later in get_chest_override. In the other case, it will just keep its vanilla appearance.
Testing
Put correct_chest_appearances to Off, then went to Forest BK room and checked that in the twisted state, the dummy BK chest was now gilded instead of brown.