Skip to content

Add ERC-165 detection for ERC6909ContentURI#6246

Merged
ernestognw merged 4 commits intoOpenZeppelin:masterfrom
PivasDesant:fix/erc6909-content-uri-supports-interface
Dec 30, 2025
Merged

Add ERC-165 detection for ERC6909ContentURI#6246
ernestognw merged 4 commits intoOpenZeppelin:masterfrom
PivasDesant:fix/erc6909-content-uri-supports-interface

Conversation

@PivasDesant
Copy link
Contributor

Missing supportsInterface override for IERC6909ContentURI. Added it so ERC165 interface detection works correctly.

@PivasDesant PivasDesant requested a review from a team as a code owner December 27, 2025 23:18
@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2025

🦋 Changeset detected

Latest commit: f0e7598

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 27, 2025

Walkthrough

The change adds interface support functionality to ERC6909ContentURI.sol. It imports IERC165 and implements a supportsInterface method that returns true when the interfaceId matches IERC6909ContentURI or delegates to the parent implementation. The new method is public, virtual, and overrides both ERC6909 and IERC165 implementations, enabling the contract to declare support for both IERC6909ContentURI and IERC165 interfaces.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, clearly explaining the purpose of adding the missing supportsInterface override for IERC6909ContentURI interface detection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The pull request title accurately and concisely describes the main change: adding ERC-165 interface detection support for the ERC6909ContentURI extension, which matches the code changes that implement the supportsInterface override.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@arr00 arr00 changed the title fix(ERC6909): add supportsInterface override for ContentURI extension Expose IERC6909ContentURI via ERC-165 on ERC6909ContentURI.sol Dec 29, 2025
@arr00 arr00 changed the title Expose IERC6909ContentURI via ERC-165 on ERC6909ContentURI.sol Add ERC-165 detection for ERC6909ContentURI Dec 29, 2025
@arr00 arr00 requested a review from ernestognw December 29, 2025 09:18
arr00
arr00 previously approved these changes Dec 29, 2025
Copy link
Member

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PivasDesant !

@arr00 arr00 requested a review from a team December 29, 2025 12:09
ernestognw
ernestognw previously approved these changes Dec 30, 2025
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ernestognw ernestognw dismissed stale reviews from arr00 and themself via f0e7598 December 30, 2025 18:05
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a changeset since this is a functionality change and I believe it should be notified to users.

@ernestognw ernestognw merged commit 0d9fcb7 into OpenZeppelin:master Dec 30, 2025
18 of 19 checks passed
@Amxx Amxx added this to the 5.6 milestone Jan 7, 2026
Amxx pushed a commit that referenced this pull request Jan 8, 2026
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants