fix issue when windows username contains dots#2
Open
yarix wants to merge 1 commit intoRedHatTraining:mainfrom
Open
fix issue when windows username contains dots#2yarix wants to merge 1 commit intoRedHatTraining:mainfrom
yarix wants to merge 1 commit intoRedHatTraining:mainfrom
Conversation
the windows user can contain dots which are not valid for namespace creation. for example with user name "first.last", the setup script fails with: ``` Creating namespace 'first.last-dev' ... The Namespace "first.last-dev" is invalid: metadata.name: Invalid value: "first.last-dev": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?') Error while creating namespace first.last-dev. ``` the solution here is to replace every '.' with '-'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the windows user can contain dots which are not valid for namespace creation.
for example with user name "first.last", the setup script fails with:
the solution here is to replace every '.' with '-'