This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Open
Conversation
Created motor_control message type for motor output Updated motor_controller to extract and publish motor output
oswinso
added
type ➤ new feature
This was referenced Nov 6, 2019
Merged
Dallas-D
reviewed
Jan 8, 2020
Contributor
Dallas-D
left a comment
Dallas-D
left a comment
There was a problem hiding this comment.
I had some questions about some of your changes
| motor_control.left = static_cast<uint8_t>(response.left_output); | ||
| motor_control.right = static_cast<uint8_t>(response.right_output); | ||
| motor_control.duration = ros::Duration(response.dt_sec); | ||
| motor_control.header.stamp = ros::Time::now() - motor_control.duration; |
Contributor
There was a problem hiding this comment.
I'm not sure why you subtracted duration from the current time. What do you want the header time to represent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently have no idea what values our MBED is sending to the motors, which is kind of scary, and hard to debug controls problems.
This PR does the following:
igvc_msgs::motor_controlmessage type for modelling the MBED output to the motors (0 - 255)igvc.pb.candigvc.pb.hto include the newleft_outputandright_outputfieldsmotor_controllerto extract the motor outputs and publish them.Fixes #403.
Testing steps (If relevant)
Test on Jessii
motor_controlleron Jessii and a joystick node, with wheels decoupledrostopic echo /motor_outputExpectation: It should values corresponding to what you are joysticking
Self Checklist
make format