tol parameter for trace_particle_through_mesh#141
Closed
Fuad-HH wants to merge 3 commits intoSCOREC:masterfrom
Closed
tol parameter for trace_particle_through_mesh#141Fuad-HH wants to merge 3 commits intoSCOREC:masterfrom
Fuad-HH wants to merge 3 commits intoSCOREC:masterfrom
Conversation
- passing all tests except smoke_test_particle It is giving a warning for MPI oversubscribing and "Structure not initalized at Particle"
- passing all tests
cwsmith
requested changes
Feb 12, 2025
Contributor
cwsmith
left a comment
cwsmith
left a comment
There was a problem hiding this comment.
Looks good. I left a comment below about passing tol.
src/pumipic_adjacency.tpp
Outdated
| bool debug, | ||
| Func& func) { | ||
| Func& func, | ||
| o::Real &tol) { |
Contributor
There was a problem hiding this comment.
Can tol be made an optional argument to avoid the 'checking for negative' logic? Something like this:
https://godbolt.org/z/Poa5haq6d
instead of checking if tol was passed using negative values, it is made optional. In the future, tol will be calculated outside according to the standardization plan and for this reason, we don't need it to be passed as reference or pointer
Contributor
Contributor
Author
Contributor
|
Yes. Closing this one makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously tolerance for the search method,
trace_particle_through_mesh, was computed every time it is called which can be unnecessary if the mesh doesn't change as described in issue #138. It involves a parallel reduction operation which can be expensive.Closes #138.