Open
Conversation
- passing all tests except smoke_test_particle It is giving a warning for MPI oversubscribing and "Structure not initalized at Particle"
- passing all tests
instead of checking if tol was passed using negative values, it is made optional. In the future, tol will be calculated outside according to the standardization plan and for this reason, we don't need it to be passed as reference or pointer
it is passed as a parameter rather than computing it every time the search is called.
jacobmerson
approved these changes
Feb 17, 2025
6 tasks
Contributor
|
@Fuad-HH Was this supposed to be closed? |
Contributor
Author
|
It was a mistake. I am sorry. Thank you for noticing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elmAreais computed using the functionmeasure_elements_real. Users may want to cache the information and avoid computing it in every search.Note:
tolis related toelmAreaand I have added your suggested changes here fortolin pull request #141