Skip to content

Comments

Support VSCodium as a client when moving cursor#3302

Merged
andyw8 merged 2 commits intoShopify:mainfrom
shanecav84:patch-1
Mar 18, 2025
Merged

Support VSCodium as a client when moving cursor#3302
andyw8 merged 2 commits intoShopify:mainfrom
shanecav84:patch-1

Conversation

@shanecav84
Copy link
Contributor

@shanecav84 shanecav84 commented Mar 15, 2025

Motivation

Closes #3156

Implementation

A simple fix adding VSCodium as a supported client name. VSCodium is a fork of VSCode.

Automated Tests

Added test for snippets on VSCodium similar to the one for Cursor.

Manual Tests

I pointed a project's Ruby LSP Gemfile config to the Gemfile of the Ruby LSP source I was working on and tested changes in my project.

@shanecav84 shanecav84 requested a review from a team as a code owner March 15, 2025 14:52
@graphite-app
Copy link

graphite-app bot commented Mar 15, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@shanecav84
Copy link
Contributor Author

I have signed the CLA!

@andyw8 andyw8 added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Mar 18, 2025
@andyw8 andyw8 enabled auto-merge (squash) March 18, 2025 13:45
@andyw8 andyw8 added enhancement New feature or request and removed enhancement New feature or request labels Mar 18, 2025
@andyw8 andyw8 merged commit b87bca5 into Shopify:main Mar 18, 2025
30 of 31 checks passed
@shanecav84 shanecav84 deleted the patch-1 branch March 20, 2025 04:30
@martinbarilik
Copy link

Support VSCodium as a client when moving cursor by @shanecav84 in https://github.com/Shopify/ruby-lsp/pull/3302

I see it got released in 0.9.9, but the problem is not resolved

the "end" part's behaviour didn't change from what i described here #3156

any idea why ?

tested with

  • gem ruby-lsp (0.23.12)
  • Ruby LSP 0.9.10 extension

@shanecav84
Copy link
Contributor Author

The VSCode extension has been updated, but the fix for the "end" part behavior is in the server, which hasn't been released yet. It looks like it will in the next version, 0.23.13.

@shanecav84
Copy link
Contributor Author

You can use the unreleased code by updating Ruby LSP's settings in VSCodium and setting "Branch" to "main", then running the "Developer Reload Window" command. The LSP server will take a bit longer to start up but you can get the updated code that way right now.

Screenshot 2025-03-20 at 7 26 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"end" autocompletion off when new line applied with formatOnType: true

4 participants