Skip to content

Support VSCodium as a client when moving cursor #3302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyw8 merged 2 commits into from
Mar 18, 2025
Merged

Support VSCodium as a client when moving cursor #3302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5618aa3
Support VSCodium as a client when moving cursor
shanecav84 Mar 15, 2025
52fabbe
Add test for snippets on VSCodium
shanecav84 Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_lsp/requests/on_type_formatting.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def add_edit_with_text(text, position = @position)

#: (Integer line, Integer character) -> void
def move_cursor_to(line, character)
return unless /Visual Studio Code|Cursor/.match?(@client_name)
return unless /Visual Studio Code|Cursor|VSCodium/.match?(@client_name)

position = Interface::Position.new(
line: line,
Expand Down
40 changes: 40 additions & 0 deletions test/requests/on_type_formatting_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,46 @@ def test_includes_snippets_on_cursor
assert_equal(expected_edits.to_json, T.must(edits).to_json)
end

def test_includes_snippets_on_vscodium
document = RubyLsp::RubyDocument.new(
source: +"",
version: 1,
uri: URI("file:///fake.rb"),
global_state: @global_state,
)

document.push_edits(
[{
range: { start: { line: 0, character: 0 }, end: { line: 0, character: 0 } },
text: "class Foo",
}],
version: 2,
)
document.parse!

edits = RubyLsp::Requests::OnTypeFormatting.new(
document,
{ line: 1, character: 2 },
"\n",
"VSCodium",
).perform
expected_edits = [
{
range: { start: { line: 1, character: 2 }, end: { line: 1, character: 2 } },
newText: "\n",
},
{
range: { start: { line: 1, character: 2 }, end: { line: 1, character: 2 } },
newText: "end",
},
{
range: { start: { line: 1, character: 2 }, end: { line: 1, character: 2 } },
newText: "$0",
},
]
assert_equal(expected_edits.to_json, T.must(edits).to_json)
end

def test_does_not_confuse_class_parameter_with_keyword
document = RubyLsp::RubyDocument.new(
source: +"",
Expand Down
Loading