Snapshot internal observers before Subscriber iterates over them#214
Merged
domfarolino merged 1 commit intomasterfrom Sep 5, 2025
Merged
Snapshot internal observers before Subscriber iterates over them#214domfarolino merged 1 commit intomasterfrom
domfarolino merged 1 commit intomasterfrom
Conversation
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2025
SHA: fdfc3b3 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 5, 2025
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 5, 2025
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 5, 2025
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 5, 2025
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Sep 10, 2025
…Subscriber iterates over them, a=testonly Automatic update from web-platform-tests WPT: Snapshot internal observers before Subscriber iterates over them This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774} -- wpt-commits: 826a9b6061c2541d55b9f04d45b8deb102283b4c wpt-pr: 54725
mertcanaltin
pushed a commit
to mertcanaltin/wpt
that referenced
this pull request
Oct 26, 2025
This behavior was already implemented in https://crrev.com/c/6311209, which was a follow-up bug fix to https://crrev.com/c/6221901. It was only recently spec'ed in WICG/observable#214, and this CL adds a WPT for it. This behavior was obliquely tested by: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as discovered in keithamus/observable-polyfill#38, however this CL adds a simpler, more direct test for this behavior. R=jarhar Bug: 40282760 Change-Id: I43748a09a2f5a235c25ffdbd807e630c187ef2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6915657 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1511774}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #197, as it missed something that I implemented in Chromium. The Subscriber algorithms should iterate over copies of the internal observers list, instead of the live list itself, in case they mutate mid-iteration, which seems kind of bad, and has some mixed opinions on in whatwg/infra#396. This PR tries to protect against the mid-iteration mutation stuff just like Chromium, mostly to be as explicit as possible.
If we decide against this behavior, we can always change it, but I like this change since there's no ambiguity (see the aforementioned issue).
Tests: this is technically tested in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/dom/observable/tentative/observable-from.any.js;l=675-740;drc=5f8643cf150e97b694f2214ee092c34cc0ccf5fe, as I discovered in keithamus/observable-polyfill#38, so I think this PR is good to go, but I'll separately add some tests for this case specifically. /cc @keithamus & @derdeka.
Preview | Diff