-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Admin UI: Reskin notices to align with WordPress Design System #10784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Update all notice styles to match Gutenberg's component patterns and the WordPress Design System specifications. **Base Notice Styles:** - Border: 4px left border only (removed generic border) - Box shadow: removed for cleaner appearance - Padding: 8px 12px (was 1px 12px) - Typography: 13px/20px, color #1e1e1e (gray-900) **Notice Type Colors:** - Info: #3858e9 border, transparent background - Success: #4ab866 border, #eff9f1 background - Warning: #f0b849 border, #fef8ee background - Error: #cc1818 border, #fcf0f0 background **Dismiss Button:** - Size: 24px × 24px (was 20px × 20px) - Position: top 8px, right 12px (improved alignment) - Color: #1e1e1e (was #787c82) - Icon size: 20px/24px (was 16px/20px) - Focus: Gutenberg-style ring using var(--wp-admin-theme-color) - Hover: opacity 0.7 **Links in Notices:** - Color: var(--wp-admin-theme-color) - Hover: var(--wp-admin-theme-color-darker-10) - Focus: proper focus ring with var(--wp-admin-border-width-focus) **Spacing:** - Dismissible notices: 48px right padding (was 38px) - Provides 24px gap between content and dismiss button See: https://core.trac.wordpress.org/ticket/64308
f445ddf to
e814c54
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of concerns; mostly OK.
|
Thanks for the review @joedolson I've addressed the items you've raised individually so this can get another look 👍 |
Trac ticket: https://core.trac.wordpress.org/ticket/64548
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.