Add vendor control type configuration #94
+154
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenetworkgrinch
requested changes
Feb 9, 2026
Collaborator
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
There may be a few more changes regarding BasicOptions in the SMCConfig
Contributor
Author
Do you consider this to be a basic option of the motor controller? |
Collaborator
|
Unfortunately yes. The basic option enum is to garuntee that the field is always handled everytime a |
Collaborator
|
Sorry for delaying this! Its going to conflict with the LQR branch when i merge it and i am debating how to handle it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new capability to use vendor ControlRequest for Talonfx and ControlType for Spark for either velocity or position.