GUACAMOLE-2113: Improve warning when WoL is enabled but no MAC address is provided#606
Conversation
There was a problem hiding this comment.
With respect to the changes themselves, LGTM.
A couple things need to be addressed before this is mergeable:
-
As a minor fix/improvement that does not impact documentation, this should be against
patchinstead ofmain. (See the documentation covering our branching scheme.) -
The commit message needs to be formatted to match established formatting (JIRA issue followed by a colon, etc.).
Since each of the messages is being modified as a part of this, these changes could be a good opportunity to make these messages consistent (ie: WoL requested vs. WoL was enabled vs. Wake on LAN was requested vs. ...). I don't think that's deal-breaking, though.
dff8eb7 to
3c6250b
Compare
Changed the target to |
…s so that the full message for incorrect WoL config is logged.
… incorrect WoL config.
3c6250b to
a22b1e0
Compare
Proposed fix for GUACAMOLE-2113
Results after local testing: