Skip to content

GUACAMOLE-2113: Improve warning when WoL is enabled but no MAC address is provided #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mike-jumper merged 2 commits into from
Aug 4, 2025
Merged

GUACAMOLE-2113: Improve warning when WoL is enabled but no MAC address is provided #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fcb1cf
GUACAMOLE-2113: Removed extra comma(,) in guac_user_log function call…
svkurupath-keeper Jul 31, 2025
a22b1e0
GUACAMOLE-2113: Same message to be logged by all protocols in case of…
svkurupath-keeper Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/protocols/rdp/settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,8 +1331,8 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,

/* If WoL has been requested but no MAC address given, log a warning. */
if(strcmp(argv[IDX_WOL_MAC_ADDR], "") == 0) {
guac_user_log(user, GUAC_LOG_WARNING, "WoL requested but no MAC ",
"address specified. WoL will not be sent.");
guac_user_log(user, GUAC_LOG_WARNING, "WoL was enabled, but no "
"MAC address was provided. WoL will not be sent.");
settings->wol_send_packet = 0;
}

Expand Down
4 changes: 2 additions & 2 deletions src/protocols/ssh/settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,8 @@ guac_ssh_settings* guac_ssh_parse_args(guac_user* user,
if (settings->wol_send_packet) {

if (strcmp(argv[IDX_WOL_MAC_ADDR], "") == 0) {
guac_user_log(user, GUAC_LOG_WARNING, "WoL was enabled, but no ",
"MAC address was provide. WoL will not be sent.");
guac_user_log(user, GUAC_LOG_WARNING, "WoL was enabled, but no "
"MAC address was provided. WoL will not be sent.");
settings->wol_send_packet = false;
}

Expand Down
4 changes: 2 additions & 2 deletions src/protocols/telnet/settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,8 @@ guac_telnet_settings* guac_telnet_parse_args(guac_user* user,

/* If WoL has been enabled but no MAC provided, log warning and disable. */
if(strcmp(argv[IDX_WOL_MAC_ADDR], "") == 0) {
guac_user_log(user, GUAC_LOG_WARNING, "Wake on LAN was requested, ",
"but no MAC address was specified. WoL will not be sent.");
guac_user_log(user, GUAC_LOG_WARNING, "WoL was enabled, but no "
"MAC address was provided. WoL will not be sent.");
settings->wol_send_packet = false;
}

Expand Down
4 changes: 2 additions & 2 deletions src/protocols/vnc/settings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,8 @@ guac_vnc_settings* guac_vnc_parse_args(guac_user* user,

/* If WoL has been enabled but no MAC provided, log warning and disable. */
if(strcmp(argv[IDX_WOL_MAC_ADDR], "") == 0) {
guac_user_log(user, GUAC_LOG_WARNING, "Wake on LAN was requested, ",
"but no MAC address was specified. WoL will not be sent.");
guac_user_log(user, GUAC_LOG_WARNING, "WoL was enabled, but no "
"MAC address was provided. WoL will not be sent.");
settings->wol_send_packet = false;
}

Expand Down