Support '2'::int statement in PostgreSQL and openGauss#37962
Merged
strongduanmu merged 8 commits intoapache:masterfrom Feb 8, 2026
Merged
Support '2'::int statement in PostgreSQL and openGauss#37962strongduanmu merged 8 commits intoapache:masterfrom
strongduanmu merged 8 commits intoapache:masterfrom
Conversation
strongduanmu
requested changes
Feb 5, 2026
| return new ParameterMarkerLimitValueSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), ((ParameterMarkerExpressionSegment) astNode).getParameterMarkerIndex()); | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(((ExpressionSegment) astNode).getText())); | ||
| return toLimitValueSegment(ctx, (ExpressionSegment) visit(ctx.aExpr())); |
Member
There was a problem hiding this comment.
Do you think createLimitValueSegment is better?
| return toLimitValueSegment(ctx, (ExpressionSegment) visit(ctx.aExpr())); | ||
| } | ||
|
|
||
| private LimitValueSegment toLimitValueSegment(final ParserRuleContext ctx, final ExpressionSegment segment) { |
Member
There was a problem hiding this comment.
Do you think createLimitValueSegment is better?
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(literals.toString())); | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(((ExpressionSegment) astNode).getText())); | ||
| throw new SQLParsingException("Unsupported LIMIT expression: " + segment.getText()); |
Member
There was a problem hiding this comment.
Why add this check? openGauss does not support limit segment?
strongduanmu
approved these changes
Feb 8, 2026
Member
strongduanmu
left a comment
strongduanmu
left a comment
There was a problem hiding this comment.
Looks so great, thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34976
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.