-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Support '2'::int statement in PostgreSQL and openGauss #37962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1c46aca
support new function
ClaireLytt 3d805b6
realese-notes
ClaireLytt fedf93c
npe
ClaireLytt 7738be3
npe
ClaireLytt f76928d
support Expression
ClaireLytt 4a56ea8
support new function
ClaireLytt fb2ad6d
update code
ClaireLytt b4bc74a
update code
ClaireLytt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,6 +118,7 @@ | |
| import org.apache.shardingsphere.sql.parser.autogen.OpenGaussStatementParser.WindowDefinitionListContext; | ||
| import org.apache.shardingsphere.sql.parser.autogen.OpenGaussStatementParser.WithClauseContext; | ||
| import org.apache.shardingsphere.sql.parser.autogen.OpenGaussStatementParserBaseVisitor; | ||
| import org.apache.shardingsphere.sql.parser.engine.exception.SQLParsingException; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.enums.AggregationType; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.enums.CombineType; | ||
| import org.apache.shardingsphere.sql.parser.statement.core.enums.JoinType; | ||
|
|
@@ -1393,29 +1394,37 @@ public ASTNode visitSelectLimitValue(final SelectLimitValueContext ctx) { | |
| if (null != ctx.ALL()) { | ||
| return null; | ||
| } | ||
| ASTNode astNode = visit(ctx.cExpr()); | ||
| if (astNode instanceof ParameterMarkerExpressionSegment) { | ||
| return new ParameterMarkerLimitValueSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), ((ParameterMarkerExpressionSegment) astNode).getParameterMarkerIndex()); | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(((ExpressionSegment) astNode).getText())); | ||
| return toLimitValueSegment(ctx, (ExpressionSegment) visit(ctx.aExpr())); | ||
| } | ||
|
|
||
| @Override | ||
| public ASTNode visitSelectOffsetValue(final SelectOffsetValueContext ctx) { | ||
| ASTNode astNode = visit(ctx.cExpr()); | ||
| if (astNode instanceof ParameterMarkerExpressionSegment) { | ||
| return new ParameterMarkerLimitValueSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), ((ParameterMarkerExpressionSegment) astNode).getParameterMarkerIndex()); | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(((ExpressionSegment) astNode).getText())); | ||
| return toLimitValueSegment(ctx, (ExpressionSegment) visit(ctx.aExpr())); | ||
| } | ||
|
|
||
| @Override | ||
| public ASTNode visitSelectFetchValue(final SelectFetchValueContext ctx) { | ||
| ASTNode astNode = visit(ctx.cExpr()); | ||
| if (astNode instanceof ParameterMarkerExpressionSegment) { | ||
| return new ParameterMarkerLimitValueSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), ((ParameterMarkerExpressionSegment) astNode).getParameterMarkerIndex()); | ||
| return toLimitValueSegment(ctx, (ExpressionSegment) visit(ctx.aExpr())); | ||
| } | ||
|
|
||
| private LimitValueSegment toLimitValueSegment(final ParserRuleContext ctx, final ExpressionSegment segment) { | ||
|
||
| if (segment instanceof ParameterMarkerExpressionSegment) { | ||
| return new ParameterMarkerLimitValueSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), | ||
| ((ParameterMarkerExpressionSegment) segment).getParameterMarkerIndex()); | ||
| } | ||
| if (segment instanceof TypeCastExpression) { | ||
| return toLimitValueSegment(ctx, ((TypeCastExpression) segment).getExpression()); | ||
| } | ||
| if (segment instanceof LiteralExpressionSegment) { | ||
| Object literals = ((LiteralExpressionSegment) segment).getLiterals(); | ||
| if (null == literals) { | ||
| return ctx instanceof SelectOffsetValueContext | ||
| ? new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), 0L) | ||
| : null; | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(literals.toString())); | ||
| } | ||
| return new NumberLiteralLimitValueSegment(ctx.start.getStartIndex(), ctx.stop.getStopIndex(), Long.parseLong(((ExpressionSegment) astNode).getText())); | ||
| throw new SQLParsingException("Unsupported LIMIT expression: " + segment.getText()); | ||
|
||
| } | ||
|
|
||
| private LimitSegment createLimitSegmentWhenLimitAndOffset(final SelectLimitContext ctx) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think createLimitValueSegment is better?