Refactor type resolution#182
Draft
heshanpadmasiri wants to merge 11 commits intoballerina-platform:mainfrom
Draft
Refactor type resolution#182heshanpadmasiri wants to merge 11 commits intoballerina-platform:mainfrom
heshanpadmasiri wants to merge 11 commits intoballerina-platform:mainfrom
Conversation
We can narrow the types of each function concurrently
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 27.90% 28.49% +0.58%
==========================================
Files 254 257 +3
Lines 53858 54306 +448
==========================================
+ Hits 15031 15473 +442
+ Misses 37890 37888 -2
- Partials 937 945 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a pre-requsit for moving type resolution to type narrowing
Unless actual type resolution of an expression depends on the context (struct constructors) they should all be resolved in the type resolver
daa9001 to
41b04e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Current design for the type resolution was based on the assumption that we need the CFG to do type narrowing so we need to do type resolution before that. But conditional type narrowing sometimes invalidate these resolved types. Fortunately it turned out we can do type narrowing without type resolution of expression. Therefore this cleans up the current implementation
Resolves #173
Depends on #150