Skip to content

Refactor type resolution #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
heshanpadmasiri wants to merge 11 commits into
base: main
Choose a base branch
from

Move type resolution logics from semantic analyzer to type resolver

41b04e5
Select commit
Loading
Failed to load commit list.
Draft

Refactor type resolution #182

Move type resolution logics from semantic analyzer to type resolver
41b04e5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 22, 2026 in 0s

28.49% (+0.58%) compared to 8e7b2a8

View this Pull Request on Codecov

28.49% (+0.58%) compared to 8e7b2a8

Details

Codecov Report

❌ Patch coverage is 85.88435% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.49%. Comparing base (8e7b2a8) to head (41b04e5).

Files with missing lines Patch % Lines
semantics/type_narrowing/type_narrowing.go 90.97% 21 Missing and 3 partials ⚠️
semantics/type_resolver.go 89.92% 9 Missing and 5 partials ⚠️
test_util/testphases/phases.go 74.41% 5 Missing and 6 partials ⚠️
ast/expressions.go 20.00% 8 Missing ⚠️
semantics/control_flow_analyzer.go 56.25% 6 Missing and 1 partial ⚠️
ast/statements.go 0.00% 5 Missing ⚠️
bir/non_terminator.go 0.00% 4 Missing ⚠️
ast/pretty_printer.go 78.57% 1 Missing and 2 partials ⚠️
desugar/statement.go 25.00% 3 Missing ⚠️
ast/node_builder.go 71.42% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   27.90%   28.49%   +0.58%     
==========================================
  Files         254      257       +3     
  Lines       53858    54306     +448     
==========================================
+ Hits        15031    15473     +442     
+ Misses      37890    37888       -2     
- Partials      937      945       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov