Refactor logic in generation text edits for array element deletion#291
Merged
KavinduZoysa merged 2 commits intoballerina-platform:1.2.xfrom Sep 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the logic for generating text edits when deleting array elements from mappings. The main purpose is to fix incorrect positioning when determining the text range to delete for array elements that are not at the beginning or end of the array.
- Fixed incorrect start position calculation for deleting middle and last array elements
- Added comprehensive test cases to validate array element deletion scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| DataMapManager.java | Fixed text edit range calculation by using endLine() instead of startLine() for previous element positioning |
| variable5.bal | Added test source file with array type definitions and initialization |
| variable6.json | Added test configuration for deleting middle array element (index 1) |
| variable7.json | Added test configuration for deleting last array element (index 2) |
| DataMappingDeleteTest.java | Added new test cases to the configuration list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...les/flow-model-generator-ls-extension/src/test/resources/delete_mapping/source/variable5.bal
Outdated
Show resolved
Hide resolved
...es/flow-model-generator-ls-extension/src/test/resources/delete_mapping/config/variable6.json
Outdated
Show resolved
Hide resolved
...es/flow-model-generator-ls-extension/src/test/resources/delete_mapping/config/variable7.json
Outdated
Show resolved
Hide resolved
KavinduZoysa
approved these changes
Sep 8, 2025
LakshanWeerasinghe
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses : wso2/product-ballerina-integrator#1170