Fix data mapping function detection to exclude regular and natural expression functions in data_mappings.bal#382
Open
dulajdilshan wants to merge 1 commit intoballerina-platform:1.4.xfrom
Conversation
01847f4 to
43888f3
Compare
12 tasks
43888f3 to
3a93f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses wso2/product-ballerina-integrator#26
Fixed the issue where all functions in
data_mappings.balwere incorrectly marked as data mapping functions. The fix ensures that only expression-bodied functions (excluding natural expression functions) are marked as data mapping functions.All Cases Covered:
transform,mapPersonToEmployee) →isDataMappedFunction: truecustomHelper) →isDataMappedFunction: falsevalidateAge) →isDataMappedFunction: falsegenerateGreeting) → Skipped entirely (not shown in results)Approach
Reference: wso2/product-ballerina-integrator#26 (comment)