Address inconsistencies in typeInfo and typeNames in mappings API#430
Merged
KavinduZoysa merged 3 commits intoballerina-platform:1.2.xfrom Oct 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a duplicate type info issue by improving type resolution for record fields and preventing duplicate type information in array type names. The changes ensure that when dealing with record field symbols, the system properly traverses to the underlying type descriptor, and that external type prefixes are only added when necessary.
- Adds special handling for RECORD_FIELD symbols to retrieve the correct module ID from the type descriptor
- Prevents duplicate module prefix addition for array types when type info already exists
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ReferenceType.java | Adds RECORD_FIELD symbol handling to correctly resolve module IDs by accessing the type descriptor |
| DataMapManager.java | Adds null check for typeInfo to prevent duplicate module prefixes in array type names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...il/src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java
Show resolved
Hide resolved
...-model-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java
Show resolved
Hide resolved
pasindufernando1
changed the title
NipunaRanasinghe
approved these changes
Oct 25, 2025
This was referenced Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Duplicate PR of #374 targetting patch 1.3.2
Fixes : wso2/product-ballerina-integrator#1439