Skip to content

Address inconsistencies in typeInfo and typeNames in mappings API #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KavinduZoysa merged 3 commits into from
Oct 25, 2025
Merged

Address inconsistencies in typeInfo and typeNames in mappings API #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a3202d
Fix arrayName having two prefixes
pasindufernando1 Oct 10, 2025
fd9c2b6
Fix incorrect record field type infos
pasindufernando1 Oct 10, 2025
11c162d
Make minor refactoring
pasindufernando1 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...del-generator-core/src/main/java/io/ballerina/flowmodelgenerator/core/DataMapManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@ private String buildArrayTypeName(MappingPort memberPort, RefType type) {
}

String arrayTypeName = memberTypeName + "[]";
if (isExternalType(type) && !isUnionMember) {
if (isExternalType(type) && !isUnionMember && memberPort.typeInfo == null) {
arrayTypeName = type.moduleInfo.modulePrefix + ":" + arrayTypeName;
}
return arrayTypeName;
Expand Down
4 changes: 4 additions & 0 deletions ...src/main/java/org/ballerinalang/diagramutil/connector/models/connector/ReferenceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,10 @@ private static ModuleInfo createTypeInfo(ModuleID moduleID) {
}

private static ModuleID getModuleID(Symbol symbol) {
if (symbol.kind() == SymbolKind.RECORD_FIELD) {
Symbol typeDescriptor = ((RecordFieldSymbol) symbol).typeDescriptor();
return getModuleID(typeDescriptor);
}
return symbol.getModule().isPresent()
? symbol.getModule().get().id()
: null;
Expand Down
Loading