Use only expression mode for maps, lists and tuples#656
Merged
LakshanWeerasinghe merged 11 commits intoballerina-platform:hotfix-1.5.1from Jan 23, 2026
Merged
Conversation
LakshanWeerasinghe
force-pushed
the
fix-expr-set
branch
from
10d1da5 to
7bfca81
Compare
kanushka
approved these changes
Jan 23, 2026
LakshanWeerasinghe
merged commit fb677a9
into
ballerina-platform:hotfix-1.5.1
3 checks passed
nipunayf
reviewed
Jan 23, 2026
Comment on lines
-636
to
-642
| if (paramType.get().typeKind() == TypeDescKind.MAP) { | ||
| matchingValueType = ValueType.MAPPING_EXPRESSION; | ||
| // convert string to a Map<String, Object> | ||
| Map<String, Object> mapValue = CommonUtils.convertMappingExprToMap( | ||
| (MappingConstructorExpressionNode) value); | ||
| value(mapValue); | ||
| } else if (paramType.get().typeKind() == TypeDescKind.RECORD) { |
Contributor
There was a problem hiding this comment.
If the change is temporary, we should ideally add a TODO comment instead of removing the entire code block. Better if we can create an issue for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes Part Of: wso2/product-ballerina-integrator#2310
There is a limitation of serializing and deserializing map and list values between expression mode and specific mode for the type in the UI. Until we find a way to resolve this limitation from the UI side we are going to only use expression mode for maps, lists and tuples.
Screen.Recording.2026-01-23.at.15.59.52.mov